Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing equals sign in code #71

Open
0tickpulse opened this issue Aug 26, 2024 · 2 comments
Open

Missing equals sign in code #71

0tickpulse opened this issue Aug 26, 2024 · 2 comments

Comments

@0tickpulse
Copy link

I had an issue with mathbox in my website, and I managed to trace it down to this line over here:

const l = (target.length = size ? size : value.length);

It seems like there might have been a mistake in the code, where a = was used instead of == or ===.
I beliebe this is the reason behind the issue in my website: Cannot assign to read only property 'length' of string 'xyz'

- const l = (target.length = size ? size : value.length);
+ const l = (target.length === size ? size : value.length);
@ChristopherChudzicki
Copy link
Collaborator

Hi @0tickpulse ! Thanks for this. That does definitely seem like a bug.

Just to help me verify that this fixes the issue you experienced, could you describe the issue you encountered, or provide the code for a reproduction? You're also welcome to make a PR to fix this issue.

@0tickpulse
Copy link
Author

I made a stackblitz that reproduces my issue, it occurs when I try to set the eulerOrder: https://stackblitz.com/edit/stackblitz-starters-afxwth?file=index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants