Update of WebDriverSampler default code by commenting duplicate Start() and End() function calls. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removal of deprecated Phantomjs. Removal of deprecated code. Addition of "SuppressWarnings" tags where needed. To de resolved at a later stage.
Project update to Selenium 4.5 and JDK 17 (undera#21)
automatically locate Edge on the system.
Fix of wiki broken links. (undera#24)
…m Seleniuṁ 4.7.0.
Addition of driver for Edge and upgrade to Seleniuṁ 4.7.2 (undera#25)
Update to Selenium 4.8.0 (undera#26)
Fix UI Proxy issue in Firefox Config and Upgrade to Selenium 4.8.1 (undera#27)
Feature/Add custom webdriver capabilites (undera#28)
Upgrade to Selenium 4.8.3 (undera#29)
Make the plugin compatible to Java 8 (undera#30)
Update to Selenium 4.9.1 (undera#31)
Upgrade to Selenium 4.10.0 (undera#32)
Commenting out sampleStart and sampleEnd fucntions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR37, users don't have to explicitly call sampleStart() and sampleEnd() functions in their WebDriverSampler anymore as the times are now handled by the WebDriverSampler itself.
If they do so, an error is thrown by JMeter (double calls).
In order to avoid confusion, I have commented out these functions in the default code when a user adds a WebDriverSampler in his script. We can remove these lines completely in the future.