Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Adding a reaction (:+1:) vs a comment (:+1:) doesn't complete signoff #30

Open
n8io opened this issue Aug 30, 2016 · 4 comments
Open

Adding a reaction (:+1:) vs a comment (:+1:) doesn't complete signoff #30

n8io opened this issue Aug 30, 2016 · 4 comments

Comments

@n8io
Copy link

n8io commented Aug 30, 2016

image

This may not be a bug. It might just need some training on how to signoff a PR too.

@paultyng
Copy link
Contributor

Yeah, I was considering this in #4, I think we should just go ahead and add it.

@paultyng
Copy link
Contributor

They are different things in the Github API, so it has to be queried separately, thats the only reason its not working yet.

@CKarper
Copy link
Contributor

CKarper commented Apr 19, 2017

I would not like this, as I use reactions to approve/disapprove specific changes in convo.

@kjvalencik
Copy link
Contributor

@Clapper I would only use a reaction on the PR, not comments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants