Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(library): Update the README for base #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

UjjwalMahar
Copy link

Added the missing README.md for the base image in the library

@UjjwalMahar UjjwalMahar changed the title feat(library): Updated the README for base fix(library): Updated the README for base Mar 11, 2024
@UjjwalMahar UjjwalMahar changed the title fix(library): Updated the README for base fix(library): Update the README for base Mar 12, 2024
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the few comments, all good besides those.

library/base/README.md Outdated Show resolved Hide resolved

```
kraft run unikraft.org/base:latest
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note that the base image is not supposed to be used by itself, and will be used by other applications.

@StefanJum StefanJum self-assigned this Aug 22, 2024
Co-authored-by: Stefan Jumarea <[email protected]>
Signed-off-by: Ujjwal Mahar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants