feat(run): Allow application args overriding from CLI #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craciunoiuc
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu [email protected]
nderjung
reviewed
Jun 7, 2024
Passing arguments from the CLI directly overrides any commands from the Kraftfile or Dockerfile. The first argument of kraft run is the context and any subsequence argument is considered an application argument. Signed-off-by: Luca Seritan <[email protected]>
|
@nderjung turns out all the runners besides one(the one I was mostly using) were already doing this, and in the last runner, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing arguments from the CLI directly overrides any commands from the Kraftfile or Dockerfile. The first argument of kraft run is the context and any subsequence argument is considered an application argument.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
Closes: #1614