-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce systemd (WIP) #1537
base: staging
Are you sure you want to change the base?
Conversation
Signed-off-by: MdSahil-oss <[email protected]>
…aft run cmd Signed-off-by: MdSahil-oss <[email protected]>
// GetArgs returns all the arguments of run command as an array of strings. | ||
func (opts *RunOptions) GetArgs() []string { | ||
args := []string{} | ||
if opts.Detach { | ||
args = append(args, "--detach") | ||
} | ||
if opts.DisableAccel { | ||
args = append(args, "--disable-acceleration") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out: https://pkg.go.dev/reflect#StructTag.Get
This will simplify getting the flag name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it 👍🏽
Hey @MdSahil-oss Do you have an estimate for when you'll restart work on this? 🙏 |
Prerequisite checklist
make fmt
on your commit series before opening this PR;Description of changes
GitHub-Closes: #1466