test(e2e): add initial CLI tests #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoine Cotten <[email protected]>
nderjung
added
area/test
nderjung
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Really necessary and useful addition to the project, thanks a lot!
Reviewed-by: Alexander Jung [email protected]
Approved-by: Alexander Jung [email protected]
nderjung
added a commit
to nderjung/kraftkit
that referenced
this pull request
Apr 25, 2023
Thanks to the introduction of our e2e tests in unikraft#392, the build workflow has become redundant. It previously served as an e2e test by building and running the command `kraft version` which in itself is tested more extensively. Signed-off-by: Alexander Jung <[email protected]>
This was referenced Apr 25, 2023
afzal442
pushed a commit
to Cloud-Hacks/kraftkit
that referenced
this pull request
Apr 29, 2023
Thanks to the introduction of our e2e tests in unikraft#392, the build workflow has become redundant. It previously served as an e2e test by building and running the command `kraft version` which in itself is tested more extensively. Signed-off-by: Alexander Jung <[email protected]> Signed-off-by: afzal442 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
Part of #370
Lays some foundation for e2e CLI tests using the Ginkgo framework.
Includes:
versionsubcommand (does it print the version, does it show the help, ...)We would ideally include more than one test suite in the initial version, but we need to address an issue while setting the config directory using CLI flags (or env vars) before we can fully isolate test cases from one another. Besides, I will be at a professional event the next three days, so submitting this as a working initial snapshot.