Implement support for LRO #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mogasergiu
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
LGTM. Just one minor nitpick.
Reviewed-by: Sergiu Moga [email protected]
This requires converting incoming netbuf chains with multiple elements to the equivalent pbuf. Signed-off-by: Marco Schlumpp <[email protected]>
mschlumpp
force-pushed
the
mschlumpp/feature/lro
branch
from
7ec96db
to
68af7e4
Compare
razvand
requested review from
mariapana
and removed request for
michpappas and
andreistan26
mariapana
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires converting incoming netbuf chains with multiple elements to the equivalent pbuf. LWIP itself can handle the larger split packets fine.
This depends on unikraft/unikraft#1339