Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly check connection and channel states during handshakes #3393

Open
benluelo opened this issue Dec 19, 2024 · 0 comments
Open

Correctly check connection and channel states during handshakes #3393

benluelo opened this issue Dec 19, 2024 · 0 comments
Labels
A-voyager Area: Our voyager relayer C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@benluelo
Copy link
Contributor

benluelo commented Dec 19, 2024

We do not currently check whether a channel is open or not while processing channel and connection handshakes. This can result in double submitting handshake datagrams, which will error. These states should be asserted in the transaction batch plugin (and perhaps elsewhere?) to ensure that the stored value is the same as the expected value (i.e. on open init, the stored state is open, etc)

@benluelo benluelo added C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-voyager Area: Our voyager relayer labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-voyager Area: Our voyager relayer C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

1 participant