Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default TAXA filter #3

Open
stijndcl opened this issue Oct 16, 2023 · 3 comments
Open

Default TAXA filter #3

stijndcl opened this issue Oct 16, 2023 · 3 comments

Comments

@stijndcl
Copy link
Contributor

The database Dockerfile hardcodes the TAXA filter to a single value: https://github.com/unipept/docker-images/blob/79bb532058e23f48fc8492811e51c37802525004/unipept-database/Dockerfile#L87C21-L87C21

Why was this done?

@pverscha
Copy link
Member

By declaring environment variables for a Docker image, you also always have to provide a default value (which is set to 9682 as an example here). The Unipept Desktop app overwrites this value when setting up a new container, and this is expected to be overwritten by the user as well (by setting a Docker environment variable through the command line).

If the user decides not to do this, the default value is used and can be seen as an example.

@stijndcl
Copy link
Contributor Author

I expected it to be set to 1 (to pull everything instead of filtering out a specific one), but I can see how it serves as a minified example. Thanks.

@pverscha
Copy link
Member

We can switch this to 1 in the future :)

@pverscha pverscha reopened this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants