Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in showUsage is not tree-shaking, when put custom showUsage at runMain. #136

Open
kazupon opened this issue Apr 8, 2024 · 0 comments

Comments

@kazupon
Copy link

kazupon commented Apr 8, 2024

Environment

npm -v
9.3.0
node -v
v18.19.1

Reproduction

repo

https://github.com/kazupon/citty-repro1

step to reproduction

# install
npm install

# build
npm run build
> [email protected] build
> unbuild

ℹ Building citty-repro1  
ℹ Cleaning dist directory: ./dist 
✔ Build succeeded for citty-repro1  
  dist/cli.cjs (total size: 29.3 kB, chunk size: 29.3 kB, exports: showUsage)  
  📦 node_modules/citty/dist/index.mjs (14 kB)
  📦 node_modules/consola/dist/core.mjs (9.79 kB)
  📦 node_modules/consola/dist/utils.mjs (2.79 kB)
  📦 node_modules/consola/dist/browser.mjs (1.75 kB)
  dist/cli.mjs (total size: 28.9 kB, chunk size: 28.9 kB, exports: showUsage) 
  📦 node_modules/citty/dist/index.mjs (14 kB)
  📦 node_modules/consola/dist/core.mjs (9.79 kB)
  📦 node_modules/consola/dist/utils.mjs (2.75 kB)
  📦 node_modules/consola/dist/browser.mjs (1.75 kB)
Σ Total dist size (byte size): 58.2 kB

# grep built-in `showUsage`
cat dist/cli.mjs | grep showUsage\$1
async function showUsage$1(cmd, parent) {
  const showUsage$1$1 = opts.showUsage || showUsage$1;
      await showUsage$1$1(...await resolveSubCommand(cmd, rawArgs));
      await showUsage$1$1(...await resolveSubCommand(cmd, rawArgs));

Describe the bug

Built-in showUsage and renderUsage are not tree-shaking, when put custom showUsage at runMain.

Additional context

related issue (comment)

rolldown/rolldown#754 (review)

As additional information, my use-case that citty is bundled with unbuild.

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant