Using authlib-injector accounts, skins are not visible in offline servers

[evan-goode]

When using authlib-injector accounts, with e.g. Ely.by or Blessing Skin, skins for your own player and for other players will not be visible on online-mode=false servers, since the skin will be requested for the player's "offline" UUID (derived from the player's username), which the authentication server is not aware of.

This issue is not present when using Drasl since Drasl will resolve offline UUIDs to the correct player and reply with the correct skin.

Previous reports: fn2006/PollyMC#107 and fn2006/PollyMC#58

Possible fixes: yushijinhun/authlib-injector#256, elyby/accounts#32

[evan-goode]

A current workaround is to use CustomSkinLoader

[lemonzest79]

why would you need to run online-mode=false on those? they authenticate with ely.by/blessing for example?

[evan-goode]

There are many (including large, public) online-mode=false servers out there that don't use any authentication system. People playing on these servers with Fjord Launcher often expect skins to "just work", even though the server is online-mode=false, since they are signed in with an Ely.by or Blessing Skin account and using authlib-injector.

But I'm kinda starting to agree with the commenters on yushijinhun/authlib-injector#256 and leaning towards wontfix. Maybe we just tell users to use CSL here.

[lemonzest79]

I know how it works, the skins are pulled from the authentication system, no system no skins, simples, its just explaining that to the "it should work" crowd I suppose

[evan-goode]

Yeah. It doesn't help that:

• Some other launchers (TL at least) use Ely.by's patched authlib, so skins on offline servers "just work"
• The UX for setting up CustomSkinLoader to load from your own skin server is not great, see https://github.com/unmojang/drasl/blob/master/doc/usage.md#customskinloader. It would be nice if CSL could, without additional configuration, load skins from "authlib's own" skin provider, set by authlib-injector or by the -Dminecraft.api.*.host args. (Maybe it already does this, I'd have to look into it)