Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to beta apis #15

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Upgrade to beta apis #15

merged 4 commits into from
Jan 18, 2024

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jan 18, 2024

Description of your changes

Migrate to beta karpenter APIs

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

k apply -f test/workload.yaml
k get nodeclaims.karpenter.sh
NAME            TYPE         ZONE         NODE                                            READY   AGE
default-6dvqb   c6g.xlarge   us-west-2b   ip-192-168-117-198.us-west-2.compute.internal   True    26m
 k get pod
NAME                        READY   STATUS    RESTARTS   AGE
workload-7bf7b77746-f4qjs   1/1     Running   0          41m
workload-7bf7b77746-g228r   1/1     Running   0          41m
workload-7bf7b77746-k9ckp   1/1     Running   0          41m
workload-7bf7b77746-n8zv6   1/1     Running   0          41m
workload-7bf7b77746-ss8c5   1/1     Running   0          41m

* Migrate to latest version and beta APIs
* make configuration installation more reliable

Signed-off-by: Yury Tsarev <[email protected]>
@ytsarev ytsarev requested a review from haarchri January 18, 2024 12:48
@ytsarev
Copy link
Member Author

ytsarev commented Jan 18, 2024

@haarchri we can also offload InstanceProfile creation to the karpenter now and rely on NodeCLass.spec.role if needed but I would leave it to additional PR

As in https://aws.amazon.com/blogs/containers/karpenter-graduates-to-beta/

The Karpenter spec.instanceProfile field has been removed from the EC2NodeClass in favor of the spec.role field. Karpenter now auto-generates the instance profile in your EC2NodeClass given the role that you specify.

In fact instanceProfile is not fully deprecated by the new capability if its management by karpenter is there

@ytsarev
Copy link
Member Author

ytsarev commented Jan 18, 2024

/test-examples

@nabuskey nabuskey mentioned this pull request Jan 18, 2024
3 tasks
To consume the latest fix

Signed-off-by: Yury Tsarev <[email protected]>
@ytsarev
Copy link
Member Author

ytsarev commented Jan 18, 2024

/test-examples

@ytsarev ytsarev merged commit 7616bb5 into upbound:main Jan 18, 2024
1 check passed
@ytsarev ytsarev deleted the upgrade-to-beta-apis branch January 18, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants