Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up logout should clear token on expired session #567

Open
nullable-eth opened this issue Jun 17, 2024 · 0 comments
Open

up logout should clear token on expired session #567

nullable-eth opened this issue Jun 17, 2024 · 0 comments
Labels
bug Something isn't working needs-epic-link Needs a link to an epic needs-points-label Needs a story points label needs-project Needs to be added to a project board

Comments

@nullable-eth
Copy link
Contributor

What happened?

up logout fails with 401 Unauthorized when the session token has expired and the token is not cleared.

Also docker pull xpkg.upbound.io/crossplane-contrib/function-go-templating:v0.4.0 is failing when previously logged in to upbound but the token has expired. This provides a 401 on the docker call because a token is passed and is invalid even though the pull only needs public access and should be granted.

This requires the user to login to get a valid token and then they can logout and the above requests succeed.

up logout should be changed to clear the local session token at all times and then the credential helper should be updated to logout the user when it receives a 401 on a request that it passed the auth session token and retry the request.

Epic #

How can we reproduce it?

What environment did it happen in?

@nullable-eth nullable-eth added bug Something isn't working needs-project Needs to be added to a project board needs-epic-link Needs a link to an epic needs-points-label Needs a story points label labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-epic-link Needs a link to an epic needs-points-label Needs a story points label needs-project Needs to be added to a project board
Projects
None yet
Development

No branches or pull requests

1 participant