Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bail:meme on the home road causes memory leaks #522

Open
joemfb opened this issue Sep 20, 2023 · 1 comment
Open

bail:meme on the home road causes memory leaks #522

joemfb opened this issue Sep 20, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@joemfb
Copy link
Member

joemfb commented Sep 20, 2023

A bail:meme (or any bail) on the home road is currently treated as an unrecoverable error, when triggered through u3m_bail(). When triggered through u3m_signal(), the error handler attempts to run garbage collection, finds leaks, and crashes.

Home-road bails can be recovered, if garbage collection is properly run to repair possible memory leaks (as opposed to detect them and assert, as it currently does). It's not clear if that can always be handled in the virtualization layer itself (manage.c), or if it always needs to be handled by the caller (serf.c, various utilities in main.c).

Fixing this would significantly improve uptime for busy ships.

see urbit/urbit#6798 for an example.

@matthew-levan matthew-levan added the bug Something isn't working label Sep 21, 2023
@joemfb
Copy link
Member Author

joemfb commented Sep 21, 2023

The mechanism to do this should also support home-road unification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants