This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Add display format option for duration + add phantomJS to dev-dep #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdesgarets
force-pushed
the
features/duration_format
branch
from
fe563f4
to
ac02a28
Compare
|
Any update on this ? |
|
Sorry Paul, I haven't had a chance to look at it yet |
pdesgarets
force-pushed
the
features/duration_format
branch
from
ac02a28
to
ad190a5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for display formatting in the duration filter : it adds a 3rd parameter to choose the formatting, following the Moment.js docs.
It also adds PhantomJS as a dev dependency.