-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy Bypass works but doesn't send client certificates along since v1.28 #3128
Comments
This is strange. Client certificates still work for me on 1.28 and 1.29 (I am on MacOS). What kind of certificates are you using? What is your bruno.json? Can you include your .bru file? For me, I am using X509 certificates in the PEM format. This is how I configured them: The relevant section in my "clientCertificates": {
"enabled": true,
"certs": [
{
"domain": "localhost",
"certFilePath": "{{certBasePath}}/.my-awesome-enterprise-service-client.crt",
"keyFilePath": "{{certBasePath}}/.my-awesome-enterprise-service-client.key",
"passphrase": ""
}
]
} |
My certs are also in the PEM format and I'm also on macOS. I've checked my "clientCertificates": {
"enabled": true,
"certs": [
{
"domain": "apiGatewayUrl1.com",
"type": "cert",
"certFilePath": "../../../../../domain1/crt.pem",
"keyFilePath": "../../../../../domain1/key.pem",
"passphrase": ""
},
{
"domain": "apiGatewayUrl2.com",
"type": "cert",
"certFilePath": "../../../../../domain2/crt.pem",
"keyFilePath": "../../../../../domain2/key.pem",
"passphrase": ""
}
]
},
Quoting myself above, is there a way to debug it? |
Hmm... That looks like it should work. I don't know of a way to check if the certificates were applied. I also checked the "history" tab of the golden edition, but it does not say anything about the certificates. |
Hmm ok. Would be nice if it could be inspected (seems to me like Error In your |
After some digging we found that it was the following issue:
Removing the proxy configuration allowed the user to continue. However, the fact that the client certificate is not picked up correctly is a bug, in my opinion. |
I have checked the following:
Describe the bug
When I upgraded to v1.28, I thought it would be fixed in v1.29, but it's still broken somehow. 😞 I downgraded back to v1.27 and it worked there. Note that I didn't change anything except upgrading (and downgrading) Bruno version - so something must have changed between these versions that breaks the behavior. See screenshots for v1.29.0 vs. v1.27.0.
Actually, is there a way to check/inspect whether the client cert is really appended in the request?
.bru file to reproduce the bug
No response
Screenshots/Live demo link
❌ v1.29.0
✅ v1.27.0
The text was updated successfully, but these errors were encountered: