Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_settings_system_wide_preferences_configure.yaml is missing full path to security binary #418

Open
RomanTatar-wandera opened this issue Aug 30, 2024 · 0 comments
Assignees

Comments

@RomanTatar-wandera
Copy link

Summary

system_settings_system_wide_preferences_configure.yaml in sonoma branch is missing full path to security binary

Steps to reproduce

    if [[ $(security -q authorizationdb read "$section" | /usr/bin/xmllint -xpath '//*[contains(text(), "group")]/following-sibling::*[1]/text()' - ) != "admin" ]]; then
      result="0"
    fi

if [[ $(security -q authorizationdb read "$section" | /usr/bin/xmllint -xpath '//*[contains(text(), "group")]/following-sibling::*[1]/text()' - ) != "admin" ]]; then

What is the current bug behavior?

Without full path attacker can put earlier into path different security binary
Instead of intended file will be executed mallicious binary
Code execution

What is the expected correct behavior?

On line 14 security -q should be /usr/bin/security -q

@robertgendler robertgendler self-assigned this Sep 3, 2024
robertgendler added a commit that referenced this issue Sep 3, 2024
robertgendler added a commit that referenced this issue Sep 3, 2024
brodjieski pushed a commit that referenced this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants