Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: getRegisterable() did no validation format #26

Open
2 tasks done
louishot opened this issue Mar 10, 2023 · 0 comments
Open
2 tasks done

🐛 Bug Report: getRegisterable() did no validation format #26

louishot opened this issue Mar 10, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@louishot
Copy link

louishot commented Mar 10, 2023

👟 Reproduction steps

    $domain_check = new Domain($data['domain']);
    var_dump($domain_check->get());
    var_dump($domain_check->getTLD());
    var_dump($domain_check->getSuffix());
    var_dump($domain_check->getRegisterable());
    var_dump($domain_check->getName());
    var_dump($domain_check->getSub());
    var_dump($domain_check->isKnown());
    var_dump($domain_check->isICANN());
    var_dump($domain_check->isPrivate());
    var_dump($domain_check->isTest());die();
string(16) "www.test-8__.com"
string(3) "com"
string(3) "com"
string(12) "test-8__.com"
string(8) "test-8__"
string(3) "www"
bool(true)
bool(true)
bool(false)
bool(false)

👍 Expected behavior

test-8__.com is not valid for Register
I think should add $domain_check->isRootDomain() to check if is a valid domain with Registerable

👎 Actual Behavior

1

🎲 Utopia Domain version

Version 0.2.x

💻 Operating system

Linux

🐘 PHP Version

PHP 8.0

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@louishot louishot added the bug Something isn't working label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant