Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage with demand frameloop #33

Open
itsdouges opened this issue Aug 7, 2022 · 1 comment
Open

Usage with demand frameloop #33

itsdouges opened this issue Aug 7, 2022 · 1 comment

Comments

@itsdouges
Copy link

itsdouges commented Aug 7, 2022

Hey mate! Love the tool. Is there any advice in how to use it when frameloop is set to "demand"? When it is you don't get FPS data, and calls, triangles, and lines display only for the render frame and then drop off immediately.

It would be great if the data would persist between frames (when there is no rendering happening). Is FPS calculated with useFrame? Could it be calcuated with rAF instead so it works when frameloop is demand?

GPU/Memory/FPS aren't calculated at all.

Keen to discuss.

@RenaudRohlinger
Copy link
Member

Hey! So I'm pretty sure it is necessary to update r3f to do so. I need to add callbacks before and after the render for r3f-perf to work by using addEffect and addTail but both these events are still getting fired when the loop is in never or demand mode. So we would need another information/callback in the render method of r3f or additional information in these hooks or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants