From 9f5e18a30af6e98960116488e03f406afff3bcfd Mon Sep 17 00:00:00 2001 From: Maisha Thasin Date: Sat, 25 Nov 2023 14:48:15 -0500 Subject: [PATCH 1/5] update node versions --- .github/workflows/lint.yml | 2 +- backend/typescript/Dockerfile | 2 +- frontend/Dockerfile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 86bc2991..339b1e71 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -39,7 +39,7 @@ jobs: if: steps.changes.outputs.frontend == 'true' || steps.changes.outputs.typescript-backend == 'true' uses: actions/setup-node@v2 with: - node-version: "14.15.5" + node-version: "16.0.0" cache: "yarn" cache-dependency-path: | frontend/yarn.lock diff --git a/backend/typescript/Dockerfile b/backend/typescript/Dockerfile index 720f95f7..2e857697 100644 --- a/backend/typescript/Dockerfile +++ b/backend/typescript/Dockerfile @@ -1,4 +1,4 @@ -FROM node:14.15.5-slim +FROM node:16.0.0-slim WORKDIR /app diff --git a/frontend/Dockerfile b/frontend/Dockerfile index edbdfea2..476e5ae9 100644 --- a/frontend/Dockerfile +++ b/frontend/Dockerfile @@ -1,4 +1,4 @@ -FROM node:14.15.5-slim +FROM node:16.0.0-slim WORKDIR /app From 3047c3d0e40e38d9812bee88c02b3da13b537433 Mon Sep 17 00:00:00 2001 From: Maisha Thasin Date: Sat, 25 Nov 2023 14:59:41 -0500 Subject: [PATCH 2/5] update engine --- backend/typescript/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/typescript/package.json b/backend/typescript/package.json index 428726d8..8edb1ed3 100644 --- a/backend/typescript/package.json +++ b/backend/typescript/package.json @@ -83,6 +83,6 @@ "graphql-upload": "^11.0.0" }, "engines": { - "node": "14.15.5" + "node": "16.0.0" } } From b12aac138652a486b740fa81f6f848f2696220ed Mon Sep 17 00:00:00 2001 From: Maisha Thasin Date: Mon, 27 Nov 2023 12:32:08 -0500 Subject: [PATCH 3/5] use legacy node --- .github/workflows/firebase-hosting-merge.yml | 1 + .github/workflows/firebase-hosting-pull-request.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/firebase-hosting-merge.yml b/.github/workflows/firebase-hosting-merge.yml index 12bd1e2d..1fc21091 100644 --- a/.github/workflows/firebase-hosting-merge.yml +++ b/.github/workflows/firebase-hosting-merge.yml @@ -21,6 +21,7 @@ jobs: - uses: actions/checkout@v2 - run: echo "REACT_APP_BACKEND_URL=${{ secrets.DEV_BACKEND_URL }}" > .env - run: echo "REACT_APP_OAUTH_CLIENT_ID=${{ secrets.DEV_OAUTH_CLIENT_ID }}" >> .env + - run: echo "NODE_OPTIONS=--openssl-legacy-provider" >> $GITHUB_ENV - run: rm -rf node_modules && yarn install --frozen-lockfile && yarn build - uses: FirebaseExtended/action-hosting-deploy@v0 with: diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml index 2e2406eb..e89af438 100644 --- a/.github/workflows/firebase-hosting-pull-request.yml +++ b/.github/workflows/firebase-hosting-pull-request.yml @@ -20,6 +20,7 @@ jobs: - uses: actions/checkout@v2 - run: echo "REACT_APP_BACKEND_URL=${{ secrets.PREVIEW_BACKEND_URL }}" > .env - run: echo "REACT_APP_OAUTH_CLIENT_ID=${{ secrets.DEV_OAUTH_CLIENT_ID }}" >> .env + - run: echo "NODE_OPTIONS=--openssl-legacy-provider" >> $GITHUB_ENV - run: rm -rf node_modules && yarn install --frozen-lockfile && yarn build - uses: FirebaseExtended/action-hosting-deploy@v0 with: From 9fbb14eb7d06ad6cf729e4b5698b6f8707c411c3 Mon Sep 17 00:00:00 2001 From: Maisha Thasin Date: Mon, 27 Nov 2023 12:37:42 -0500 Subject: [PATCH 4/5] use node 16 for workflow --- .github/workflows/firebase-hosting-merge.yml | 3 +++ .github/workflows/firebase-hosting-pull-request.yml | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/firebase-hosting-merge.yml b/.github/workflows/firebase-hosting-merge.yml index 1fc21091..ba47fc2c 100644 --- a/.github/workflows/firebase-hosting-merge.yml +++ b/.github/workflows/firebase-hosting-merge.yml @@ -19,6 +19,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 + - uses: actions/setup-node@v2 + with: + node-version: '16' - run: echo "REACT_APP_BACKEND_URL=${{ secrets.DEV_BACKEND_URL }}" > .env - run: echo "REACT_APP_OAUTH_CLIENT_ID=${{ secrets.DEV_OAUTH_CLIENT_ID }}" >> .env - run: echo "NODE_OPTIONS=--openssl-legacy-provider" >> $GITHUB_ENV diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml index e89af438..75329bb7 100644 --- a/.github/workflows/firebase-hosting-pull-request.yml +++ b/.github/workflows/firebase-hosting-pull-request.yml @@ -18,9 +18,12 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 + - uses: actions/setup-node@v2 + with: + node-version: '16' - run: echo "REACT_APP_BACKEND_URL=${{ secrets.PREVIEW_BACKEND_URL }}" > .env - run: echo "REACT_APP_OAUTH_CLIENT_ID=${{ secrets.DEV_OAUTH_CLIENT_ID }}" >> .env - - run: echo "NODE_OPTIONS=--openssl-legacy-provider" >> $GITHUB_ENV + #- run: echo "NODE_OPTIONS=--openssl-legacy-provider" >> $GITHUB_ENV - run: rm -rf node_modules && yarn install --frozen-lockfile && yarn build - uses: FirebaseExtended/action-hosting-deploy@v0 with: From a21fb73a23823f62bac7530dc13d7b2efae787f2 Mon Sep 17 00:00:00 2001 From: Maisha Thasin Date: Tue, 28 Nov 2023 23:09:33 -0500 Subject: [PATCH 5/5] remove the open ssl --- .github/workflows/firebase-hosting-merge.yml | 1 - .github/workflows/firebase-hosting-pull-request.yml | 1 - 2 files changed, 2 deletions(-) diff --git a/.github/workflows/firebase-hosting-merge.yml b/.github/workflows/firebase-hosting-merge.yml index ba47fc2c..0abe823a 100644 --- a/.github/workflows/firebase-hosting-merge.yml +++ b/.github/workflows/firebase-hosting-merge.yml @@ -24,7 +24,6 @@ jobs: node-version: '16' - run: echo "REACT_APP_BACKEND_URL=${{ secrets.DEV_BACKEND_URL }}" > .env - run: echo "REACT_APP_OAUTH_CLIENT_ID=${{ secrets.DEV_OAUTH_CLIENT_ID }}" >> .env - - run: echo "NODE_OPTIONS=--openssl-legacy-provider" >> $GITHUB_ENV - run: rm -rf node_modules && yarn install --frozen-lockfile && yarn build - uses: FirebaseExtended/action-hosting-deploy@v0 with: diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml index 75329bb7..31d164bc 100644 --- a/.github/workflows/firebase-hosting-pull-request.yml +++ b/.github/workflows/firebase-hosting-pull-request.yml @@ -23,7 +23,6 @@ jobs: node-version: '16' - run: echo "REACT_APP_BACKEND_URL=${{ secrets.PREVIEW_BACKEND_URL }}" > .env - run: echo "REACT_APP_OAUTH_CLIENT_ID=${{ secrets.DEV_OAUTH_CLIENT_ID }}" >> .env - #- run: echo "NODE_OPTIONS=--openssl-legacy-provider" >> $GITHUB_ENV - run: rm -rf node_modules && yarn install --frozen-lockfile && yarn build - uses: FirebaseExtended/action-hosting-deploy@v0 with: