Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COUNTALL should emit count(*) in SQL generation #504

Open
senderista opened this issue Mar 4, 2016 · 0 comments
Open

COUNTALL should emit count(*) in SQL generation #504

senderista opened this issue Mar 4, 2016 · 0 comments
Assignees
@senderista
Labels
enhancement

Comments

@senderista
Copy link
Contributor

Since count(*) is parsed to COUNTALL in the SQL and MyriaL parsers, COUNTALL should be translated to count(*) in SQL generation. The intended semantics are exactly the same (count all tuples regardless of NULL values). Even though we don't support NULL in raco or Myria, it's possible that count(*) can be more effectively optimized in Postgres than count($0), and the semantics will be correct if/when we do decide to support NULL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senderista senderista

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@senderista