Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up boat_interfaces/config/parameters.yaml #23

Open
matthew-reynolds opened this issue Nov 26, 2018 · 2 comments
Open

Split up boat_interfaces/config/parameters.yaml #23

matthew-reynolds opened this issue Nov 26, 2018 · 2 comments

Comments

@matthew-reynolds
Copy link
Member

Currently, we have a bloated config file that handles configuration for nodes in various packages, but this central config file lives in the boat_interfaces package. This should at minimum be moved to boat_description, and ideally just split into config files in each package with parameters pertaining to that specific package.

In my mind, the ideal config would be each package having its own independent config file for parameters relating to that package. Boat physics and modelling parameters belong in boat_description where they are accessible by all packages. Physical constants and parameters can be hard coded, but in most cases should live in the boat_utilities package.

@matthew-reynolds
Copy link
Member Author

#21 (comment)

@matthew-reynolds
Copy link
Member Author

#21 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant