From 0cb9e816d9bf962788d0a666bb203bfcfadae903 Mon Sep 17 00:00:00 2001 From: Sergey Kopienko Date: Thu, 13 Jun 2024 11:05:29 +0200 Subject: [PATCH] include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h - fix review comment: the __parallel_or_tag overload takes __comp as a parameter but discards it without use. Signed-off-by: Sergey Kopienko --- .../dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h b/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h index 130edf8744c..2765189d4ea 100644 --- a/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h +++ b/include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl.h @@ -1002,16 +1002,7 @@ struct __parallel_or_tag static constexpr _AtomicType __found_state = 1; static constexpr _AtomicType __not_found_state = 0; - struct __compare_state - { - bool - operator()(const _AtomicType __found_local, const _AtomicType __found) const - { - return __found_local == __found_state && __found == __not_found_state; - } - }; - - using _Compare = __compare_state; + struct _Compare{}; // The template parameter is intended to unify __init_value in tags. template @@ -1034,7 +1025,7 @@ struct __early_exit_find_or template void - operator()(const _NDItemId __item_id, const _IterSize __n_iter, const _WgSize __wg_size, _Compare __comp, + operator()(const _NDItemId __item_id, const _IterSize __n_iter, const _WgSize __wg_size, _Compare, _FoundLocalState& __found_local, __parallel_or_tag, _Ranges&&... __rngs) const { const auto __n = oneapi::dpl::__ranges::__get_first_range_size(__rngs...);