Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Update supported cmake version #619

Open
iMartyan opened this issue Dec 11, 2024 · 4 comments · May be fixed by #621
Open

[cmake] Update supported cmake version #619

iMartyan opened this issue Dec 11, 2024 · 4 comments · May be fixed by #621
Assignees
@Rbiessy
Labels
accepted The issue/feature is confirmed and going to be implemented build A request to change/fix/improve the build system documentation A request to change/fix/improve the documentation

Comments

@iMartyan
Copy link
Contributor

Summary

Version of supported cmake shall be updated.

Observed behavior

When building with cmake 3.22.x build fails with error:
CMake Error at src/CMakeLists.txt:47 (set_target_properties): INTERFACE_LIBRARY targets may only have whitelisted properties. The property "DEPRECATION" is not allowed.
Updating cmake to 3.25.x solves the issue.
@iMartyan iMartyan added the documentation A request to change/fix/improve the documentation label Dec 11, 2024
@Rbiessy Rbiessy added accepted The issue/feature is confirmed and going to be implemented build A request to change/fix/improve the build system labels Dec 12, 2024
@Rbiessy Rbiessy self-assigned this Dec 12, 2024
@Rbiessy
Copy link
Contributor

Rbiessy commented Dec 12, 2024

Thank you for the issue, I forgot to test the minimum cmake version. I'll look into this.

@Rbiessy Rbiessy linked a pull request Dec 12, 2024 that will close this issue
Open
@Rbiessy
Copy link
Contributor

Rbiessy commented Dec 12, 2024

@iMartyan I can confirm I get the same error than you do with CMake 3.13.5 but it worked fine with 3.22.1. Can you confirm which version faced this issue exactly?

@iMartyan
Copy link
Contributor Author

@Rbiessy Sorry for confusion. I've checked the version, it was 3.16.3
3.22.1 also worked fine for me

@iMartyan
Copy link
Contributor Author

Seems like this was an issue with cmake older that 3.19:
https://cmake.org/cmake/help/v3.18/manual/cmake-buildsystem.7.html#interface-libraries
Thanks for quick response and fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rbiessy Rbiessy

Labels
accepted The issue/feature is confirmed and going to be implemented build A request to change/fix/improve the build system documentation A request to change/fix/improve the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: Only set deprecated property when supported Rbiessy/oneMath
2 participants
@Rbiessy @iMartyan