From b825be306f6d478445dc682beb72b8641977901f Mon Sep 17 00:00:00 2001
From: Alan Forbes <alan.forbes@codeplay.com>
Date: Tue, 14 Jan 2025 15:40:54 +0000
Subject: [PATCH] Add comments following review.

---
 .github/actions/do_build_opencl_cts/action.yml |  3 ++-
 .github/actions/run_opencl_cts/action.yml      |  1 +
 .github/workflows/planned_testing_caller.yml   | 12 ++++++------
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/.github/actions/do_build_opencl_cts/action.yml b/.github/actions/do_build_opencl_cts/action.yml
index c12a67d31..a5d92bda2 100644
--- a/.github/actions/do_build_opencl_cts/action.yml
+++ b/.github/actions/do_build_opencl_cts/action.yml
@@ -35,7 +35,7 @@ runs:
         repository: KhronosGroup/OpenCL-CTS
         path: OpenCL-CTS
 
-    - name: aarch64 set-up
+    - name: aarch64 set-up # TODO: update if/when qemu no longer used
       if: steps.calc_vars.outputs.arch == 'aarch64'
       shell: bash    
       run: |
@@ -45,6 +45,7 @@ runs:
         sudo apt-get install --yes gcc-aarch64-linux-gnu g++-aarch64-linux-gnu
         sudo apt-get update
         if [[ "${{inputs.target}}" =~ .*aarch64.* ]] ; then
+          # TODO: Only needed for run - could be moved to corresponding run action
           echo QEMU INSTALL MATCH FOR ${{inputs.target}}
           sudo apt-get install --yes qemu-user
         fi
diff --git a/.github/actions/run_opencl_cts/action.yml b/.github/actions/run_opencl_cts/action.yml
index 4470c556f..50210bf47 100644
--- a/.github/actions/run_opencl_cts/action.yml
+++ b/.github/actions/run_opencl_cts/action.yml
@@ -35,6 +35,7 @@ runs:
           QEMU_SETTING="-p qemu --qemu '/usr/bin/qemu-aarch64 -L /usr/aarch64-linux-gnu'"
         fi
         set -x
+        # Note: use 'eval' built-in to handle quoting/escaping/splitting reqs
         RUN_CITIES="python -u $GITHUB_WORKSPACE/scripts/testing/run_cities.py -v \
           --color=always --timeout $CTS_TIMEOUT \
           $QEMU_SETTING \
diff --git a/.github/workflows/planned_testing_caller.yml b/.github/workflows/planned_testing_caller.yml
index 71c5d4d54..68d394f02 100644
--- a/.github/workflows/planned_testing_caller.yml
+++ b/.github/workflows/planned_testing_caller.yml
@@ -2,12 +2,12 @@
 name: Run planned testing
 on:
   # Note: use pull_request: for localized testing only
-  pull_request:
-    paths:
-      - '.github/workflows/planned_testing.yml'
-      - '.github/workflows/planned_testing_caller.yml'
-    branches:
-      - main
+  #pull_request:
+  #  paths:
+  #    - '.github/workflows/planned_testing.yml'
+  #    - '.github/workflows/planned_testing_caller.yml'
+  #  branches:
+  #    - main
   schedule:
     # Run Mon-Fri at 7pm
     - cron: '00 19 * * 1-5'