Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Warnings #4

Open
fschlimb opened this issue Oct 30, 2018 · 1 comment
Open

Performance Warnings #4

fschlimb opened this issue Oct 30, 2018 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fschlimb
Copy link
Contributor

It'd be nice to get performance warnings in certain cases, such as

  • repeated use of non-contiguous ndarrays leads to repeated conversion to DAAL tables
  • different input types than algorithm's fptype waste a lot of time in conversion
@fschlimb fschlimb added the enhancement New feature or request label Oct 30, 2018
@fschlimb fschlimb added the good first issue Good for newcomers label Nov 9, 2018
@fschlimb
Copy link
Contributor Author

fschlimb commented Nov 9, 2018

@triskadecaepyon Requires a simple check and message print in src/daal4py.cpp:_make_nt

@fschlimb fschlimb mentioned this issue Nov 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fschlimb