Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google@cn需要去掉full: #2228

Open
him007 opened this issue Jul 8, 2024 · 6 comments · Fixed by #2229
Open

google@cn需要去掉full: #2228

him007 opened this issue Jul 8, 2024 · 6 comments · Fixed by #2229

Comments

@him007
Copy link
Contributor

him007 commented Jul 8, 2024

https://github.com/v2fly/domain-list-community/blob/master/data/google 里面的 google@cn 来源于 https://github.com/felixonmars/dnsmasq-china-list/blob/master/google.china.conf ，前面加上了 full: ，导致子域名不匹配到。
例如：full:gvt1-cn.com @cn匹配不到r3---sn-j5o7dn7l.gvt1-cn.com
rootmelo92118 added a commit that referenced this issue Jul 8, 2024
@rootmelo92118
Update google
5ffb91d 
fix #2228
@rootmelo92118 rootmelo92118 mentioned this issue Jul 8, 2024
Merged
@him007
Copy link
Contributor Author

him007 commented Jul 8, 2024

补充：
上游用的是 dnsmasq 格式，会匹配到子域名。需要修改成和上游一样匹配到子域名。

@him007
Copy link
Contributor Author

him007 commented Jul 12, 2024

今天看了apple的数据，也是加上了full:
搜索一下发现以前的相关讨论：

@Barry-SH Barry-SH mentioned this issue Jul 22, 2024
Merged
@IceCodeNew
Copy link
Collaborator

我看明白了，其实这个是有道理的。我印象中好像我以前也修过……我得翻翻历史记录看看后来是不是有什么问题

@him007
Copy link
Contributor Author

him007 commented Jul 26, 2024

我看明白了，其实这个是有道理的。我印象中好像我以前也修过……我得翻翻历史记录看看后来是不是有什么问题

Loyalsoldier/v2ray-rules-dat#163
总结一下应该是v2ray的DNS匹配问题和路由规则的匹配逻辑，去掉full:后可能有影响。我用的是clash，无法测试。

@IceCodeNew
Copy link
Collaborator

DNS 相关的问题都是下游的 fork 引入的，那个也已经修复了
目前我没看到不应该做这个修复的理由，我会先自己测试一段时间，然后来允许相关的修复 pr 合并

@IceCodeNew IceCodeNew pinned this issue Jul 26, 2024
IceCodeNew added a commit that referenced this issue Jul 26, 2024
@rootmelo92118 @IceCodeNew
Update google (#2229)
737fe37 
* Update google

fix #2228

* Update google

---------

Co-authored-by: IceCodeNew <[email protected]>
@IceCodeNew IceCodeNew reopened this Jul 26, 2024
@IceCodeNew
Copy link
Collaborator

IceCodeNew commented Jul 26, 2024 •
edited
Loading

Further process requested, #2259 shoule be a good example.

Lsyx-Good pushed a commit to Lsyx-Good/domain-list-community that referenced this issue Aug 7, 2024
@rootmelo92118 @IceCodeNew @Lsyx-Good
Update google (v2fly#2229)
a457ea1 
* Update google

fix v2fly#2228

* Update google

---------

Co-authored-by: IceCodeNew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update google v2fly/domain-list-community
2 participants
@him007 @IceCodeNew