Improve the name mechanism of vineyard objects. #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make sure one name is associated with one vineyard object. * Fix the name can't be all digits. * Support delete vineyard object by name. Signed-off-by: Ye Cao <[email protected]>
sighingnow
requested changes
Nov 12, 2024
| @@ -57,6 +57,14 @@ namespace vineyard { | |||
| } while (0) | |||
| #endif // ENSURE_VINEYARDD_READY | |||
|
|
|||
| // Helper function to adjust the name if it's all digits. | |||
| std::string AdjustName(const std::string& name) { | |||
| if (std::regex_match(name, std::regex("[0-9]+$"))) { | |||
There was a problem hiding this comment.
Use https://en.cppreference.com/w/cpp/string/byte/isdigit. Regex is expensive.
| // as the nlohmann/json can't convert '/names/1234: 12345' to 'names:{"1234", | ||
| // "12345"}' | ||
| std::string new_name = AdjustName(name); | ||
| std::cout << "new_name is: " << new_name << std::endl; |
There was a problem hiding this comment.
Remove those debugging logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Fixes #2003