-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
many vaadin addons not working with vaadin flow 24.3.3 #66
Comments
We are talking about this component? https://vaadin.com/directory/component/ace-widget1 if so, it is better to report this issue in the component repository at https://github.com/Sergio70/AceEditorV14/issues Looking at the release notes, it might be marked "14+" without actually testing it on 24, but problem can also be in the integrated JS. |
I am not talking only about ace-widget1 component. The full list of addons i tried to integrate with the same problem is the following: https://vaadin.com/directory/component/full-calendar-flow |
Ok, I see. I made a PR to ace-widget with the necessary V24 updates to see what what might be the issue. From 14 to 24 the biggest change is to Jakarta EE which is not compatible, but in this case I think it is the (Edit: There is now Vaadin 24 compatible version of ace-widget at There is now released version for Vaadin 24+ at https://vaadin.com/directory/component/ace-widget1/2.0.0) |
Hello. As a maintainer of grid-exporter-add-on and year-month-calendar-add-on, I can confirm that both of them should work with Vaadin 24.3 (indeed, our demo site was at 24.3 until a few weeks ago when we upgraded to 24.4.alpha). Please note that you have to add If that doesn't fix the issue, please create a new one in any of the add-on repositories, since vaadin/directory is intended for issues with the Directory itself, and we add-on authors don't monitor it actively: |
An update. |
Thanks for the update! this this likely two different problems: general compatibility with Quarkus and add-on compatibility with Vaadin versions. |
Tested quickly with the ace add-on and it looks like the "dev mode" can't handle add-on components that have client-side extensions (add-ons that trigger npm build) properly. Running in production mode works though. So the workaround is (if you don't need anything else from the dev-mode):
|
I guess this is the issue: https://vaadin.com/docs/latest/integrations/quarkus#quarkus.vaadin.addons |
Verified, with e.g. ace widget, adding these to application.properties everything seems to work fine for me:
|
I confirm that works fine |
Thanks for letting us know! Looks like we need some extra information for Quarkus users. The errors are really misleading. I created #68 We can continue discussing the solutions there. |
Just for my understanding with this solution, do we still need the production profile? |
Yes, you should use production build when building a production artifact. This way the front-end bundle is optimised and the final artifact is slimmer (and doesn't need npm). For example in your CI pipeline your build should be |
Okay my question was obviously ambiguous. I was wondering if i need the production profile for Dev mode when I want the ace editor to work. I use the dev mode a lot because of the automatic recompile and restart. |
Ah :-) I don't think it is needed then. At least my dev mode started just fine and the ace add-on was shown once the jandex index was there. I guess we could encourige add-on developers to generate jandex index automatically. Like making OSGi bunde, it is pretty much one time job and then makes the jar file more compatible 🤷♂️ |
Awesome that worked for me! Thanks a lot. |
I cannot include in my vaadin projects many addons, certified for vaadin 24, because they are not visible in web pages.
I noticed this problem for addons that wrap javascript component, like ace editor.
I do not know if the javascript error showed in the image below could be related with this issue or i missed some build step.
This is my development environment:
my pom.xml
The text was updated successfully, but these errors were encountered: