Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Vatican holidays #2184

Open
9 of 12 tasks
LBreda opened this issue Dec 19, 2024 · 3 comments
Open
9 of 12 tasks

Improve Vatican holidays #2184

LBreda opened this issue Dec 19, 2024 · 3 comments
Assignees
@PPsyrius
Labels
woc2025

Comments

@LBreda
Copy link

LBreda commented Dec 19, 2024 •
edited by PPsyrius
Loading

Bug Report

Expected Behavior

The Vatican holidays being correct

Actual Behavior

The Vatican holidays in this package are pretty neat. Still, something is missing:

  • Thursday before Easter (Maundy Thursday)
  • Friday before Easter (Good Friday)
  • Saturday before Easter (Holy Saturday)
  • Tuesday after Easter ("In Albis" Tuesday)
  • Pentecost (49 days after Easter, always a Sunday obviously)
  • Holy Trinity feast (56 days after Easter)
  • Mary Mother of God (January 1st)
  • Blessed Virgin Mary of Lourdes (February 11th, don't know if it is the actual name in English)
  • August 14th and 16th are holidays in the Vatican, a sort of summer holiday along with August 15 (already included in the package)
  • November 2nd (All Souls' Day)
  • December 27 (St. John's Day, actually a sort of Christmas holiday)
  • December 31 (St. Sylvester's Day, actually a sort of New Year's Eve holiday)

Steps to Reproduce the Problem

Simply using the system

Environment

Any

Additional Context

The calendars by the Vatican Pharmacy may be a source:
@arkid15r arkid15r changed the title Vatican holidays Update vatican holidays Dec 19, 2024
@arkid15r
Copy link
Collaborator

Hi @LBreda
thanks for the detailed explanation.

I added a couple of labels for WInter Of Code students and just volunteers in general to help with this.
Really appreciate the source links too!

@arkid15r arkid15r changed the title Update vatican holidays Improve Vatican holidays Dec 20, 2024
@LBreda
Copy link
Author

LBreda commented Jan 2, 2025

2025 calendar for further reference: https://www.farmaciavaticana.va/media/attachments/2025/01/02/calendario-2025.pdf

@PPsyrius PPsyrius self-assigned this Jan 4, 2025
@PPsyrius
Copy link
Collaborator

PPsyrius commented Jan 5, 2025 •
edited
Loading

For English version of date names I found another usable source here: https://easydiplomacy.com/en/info-directory/factsheets/vatican/public-holidays/

I'm thinking of adding en_US, it, th l10n support as well while we're adding these extra days in (not sure about la as we lacks the source for them despite Vatican technically de jure uses them)

Additional Cross-Check ref for other years:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PPsyrius PPsyrius

Labels
woc2025
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LBreda @arkid15r @PPsyrius