From 223fa6e64a7f9cdec679a599f3dac98ed0a01736 Mon Sep 17 00:00:00 2001 From: Alejandro Cabeza Romero Date: Fri, 6 Sep 2024 15:02:51 +0200 Subject: [PATCH 1/3] Fix dependency solver flag not being parsed. --- .github/workflows/daily_common.yml | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/daily_common.yml b/.github/workflows/daily_common.yml index be8f22cec4..10f2f09a5f 100644 --- a/.github/workflows/daily_common.yml +++ b/.github/workflows/daily_common.yml @@ -85,18 +85,17 @@ jobs: - name: Install dependencies run: | - nimble install -y --depsOnly + if [[ "${{ inputs.use_sat_solver }}" == "true" ]]; then + dependency_solver_flag="--solver:sat" + else + dependency_solver_flag="--solver:legacy" + fi + + nimble install ${dependency_solver_flag} -y --depsOnly - name: Run tests run: | nim --version nimble --version - if [[ "${{ inputs.use_sat_solver }}" == "true" ]]; then - dependency_solver="sat" - else - dependency_solver="legacy" - fi - - NIMFLAGS="${NIMFLAGS} --mm:${{ matrix.nim.memory_management }} --solver:${dependency_solver}" - nimble test + NIMFLAGS="${NIMFLAGS} --mm:${{ matrix.nim.memory_management }}" nimble test From b34c2c00cd4e113124ad76af07c4f329682b7e87 Mon Sep 17 00:00:00 2001 From: Alejandro Cabeza Romero Date: Fri, 6 Sep 2024 15:04:15 +0200 Subject: [PATCH 2/3] Trigger daily sat on pull request. --- .github/workflows/daily_sat.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/daily_sat.yml b/.github/workflows/daily_sat.yml index f9bb9d7ff0..2b10eafa97 100644 --- a/.github/workflows/daily_sat.yml +++ b/.github/workflows/daily_sat.yml @@ -3,6 +3,7 @@ name: Daily SAT on: schedule: - cron: "30 6 * * *" + pull_request: workflow_dispatch: jobs: From 1894c71e4aa177a1c096b4322343b9f11aac832a Mon Sep 17 00:00:00 2001 From: Alejandro Cabeza Romero Date: Wed, 16 Oct 2024 17:22:22 +0200 Subject: [PATCH 3/3] Remove pull_request trigger. --- .github/workflows/daily_sat.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/daily_sat.yml b/.github/workflows/daily_sat.yml index 2b10eafa97..f9bb9d7ff0 100644 --- a/.github/workflows/daily_sat.yml +++ b/.github/workflows/daily_sat.yml @@ -3,7 +3,6 @@ name: Daily SAT on: schedule: - cron: "30 6 * * *" - pull_request: workflow_dispatch: jobs: