Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for java client release pipeline #1922

Merged
merged 18 commits into from
Jul 17, 2024
Merged

Fixes for java client release pipeline #1922

merged 18 commits into from
Jul 17, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Jul 11, 2024 •
edited
Loading 

GLIDE_RELEASE_VERSION=x.y.z-SNAPSHOT ./gradlew :client:publishToMavenLocal

deploys a package to local maven repository with given snapshot version. Use -SNAPSHOT postfix to skip the signing. Thanks @acarbonetto.

@Yury-Fridlyand
Fix release version for java client.
24cd233 
Rework java CD.

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added java issues and fixes related to the java client CI CI/CD related labels Jul 11, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner July 11, 2024 00:17
@Yury-Fridlyand
cleanup
eb2d52e 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Suppress all javadoc errors.
b7ce7f6 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jul 11, 2024
Merged
acarbonetto
acarbonetto approved these changes Jul 11, 2024
View reviewed changes
java/client/build.gradle Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand changed the title Fix release version for java client. Fixes for java client release pipeline Jul 11, 2024
yipin-chen
yipin-chen approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one CI failure related to javadoc.
Do we need to port the changes in build.gradle to examples/java too?

@Yury-Fridlyand Yury-Fridlyand marked this pull request as draft July 11, 2024 18:08
@Yury-Fridlyand
Copy link
Collaborator Author

There is one CI failure related to javadoc. Do we need to port the changes in build.gradle to examples/java too?

CI fixed. I don't see anything should be updated in examples.

@Yury-Fridlyand Yury-Fridlyand marked this pull request as ready for review July 16, 2024 17:01
barshaul
barshaul reviewed Jul 17, 2024
View reviewed changes
java/DEVELOPER.md Outdated Show resolved Hide resolved
barshaul
barshaul approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the versions in the developer.md file from 1.0.0 to 1.0.1

@Yury-Fridlyand
Copy link
Collaborator Author

Updated

@Yury-Fridlyand Yury-Fridlyand merged commit 087826b into main Jul 17, 2024
16 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/yuryf-release-with-javadocs branch July 17, 2024 17:05
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jul 17, 2024
Merged
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jul 18, 2024
@Yury-Fridlyand @cyip10
Fixes for java client release pipeline (valkey-io#1922)
9aa12af 
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barshaul barshaul barshaul approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
CI CI/CD related java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yury-Fridlyand @barshaul @acarbonetto @yipin-chen