Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip CRC64 checksumming when doing diskless replication #1129

Open
madolson opened this issue Oct 5, 2024 · 1 comment
Open

Skip CRC64 checksumming when doing diskless replication #1129

madolson opened this issue Oct 5, 2024 · 1 comment
Assignees
Labels
help wanted External contributions would be appreciated

Comments

@madolson
Copy link
Member

madolson commented Oct 5, 2024

When we are not writing to disk (either on the primary or replica) there isn't a lot of sense in doing CRC64 checksumming during fullsync. We do checking summing at the TCP layer already. At AWS we've seen it can take up to 15% overhead for not much of a benefit. We should look into a mechanism so that a replica can indicate that it will load something directly into memory, since today we only indicate we support the EOF marker. The replica might still choose to save the RDB file to disk unless repl-diskless-load is enabled. With this mechanism in place, we should be able to skip the checksum for replication, while still using it for RDB.

@madolson madolson added the help wanted External contributions would be appreciated label Oct 5, 2024
@Shivshankar-Reddy
Copy link
Contributor

Hi @madolson , Please assign this to me, I will work on it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted External contributions would be appreciated
Projects
None yet
Development

No branches or pull requests

2 participants