Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting datesDisabled breaks inline datepicker bsValueChange-Event #6263

Closed
evilstiefel opened this issue Aug 11, 2021 · 2 comments · Fixed by #6339
Closed

Setting datesDisabled breaks inline datepicker bsValueChange-Event #6263

evilstiefel opened this issue Aug 11, 2021 · 2 comments · Fixed by #6339
Labels
comp(datepicker) issue needs: demo demo for this feature / fix should be added v7

Comments

@evilstiefel
Copy link

evilstiefel commented Aug 11, 2021

Bug description:

When using bs-datepicker-inline, disabling dates "asynchronously" (e.g., after the component has been created) breaks firing of bsValueChange.

Plunker/StackBlitz that reproduces the issue:

https://stackblitz.com/github/evilstiefel/ngx-bootstrap-datepicker-repro

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap: 7.0.0

Angular: 12.2.0

Bootstrap: 5.1.0

Expected behavior

I would expect to be able to set the datesDisabled property at any time, disabling dates, and not breaking change detection or the EventEmitter for bsValueChange.

@evilstiefel
Copy link
Author

evilstiefel commented Aug 12, 2021

Apparently this already has an open PR and several tickets related to it (e.g. #5888, #5914). This is the PR: #6201 - hopefully this can be looked at and merged ASAP.

@rfrcarvalho
Copy link

rfrcarvalho commented Sep 27, 2021

This is also happening when setting the dateCustomClasses asynchronously (e.g., after the component has been created). If I hide the component with an *ngIf and then show it again, it will display the custom classes correctly. Is there any ETA on a resolution for this?

@apotapcukv apotapcukv added the needs: demo demo for this feature / fix should be added label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp(datepicker) issue needs: demo demo for this feature / fix should be added v7
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants