-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Good First Issues]: implement function "now" - 4 points #430
Comments
I would like to try this out. Please assign it to me. |
I'd love to implement this function, please assign this issue to me. |
Hi @pradeepnnv, Thank you for your interest in contributing to this function. I have assigned it to you. For better communication in the future join our Slack community |
hi @thiyagarajan17, We would love to have you contribute to another function Issue. |
@pradeepnnv How is your progress? |
Please make sure to move the function to internal/primitive/transform/action/datatime |
Hello @pradeepnnv, I wanted to check in with you regarding the issue you expressed interest in writing a function for. I haven't heard from you in a while, so I was wondering if you're still interested in working on it. Please let me know if you are, otherwise, I will need to assign the task to someone else who is available and willing to work on it. |
Hi @Michaelg22 , sorry for the delay in my response. I'm currently working on this task. I do have a clarification though. I created the now function as you instructed. But should I create an implementation in internal/primitive/transform/function/datatime_functions.go? Please refer to the draft PR https://github.com/vanus-labs/vanus/pull/456/files#diff-edfabcf9030ccd0417dda452deaf96583455c624c09f075bc1ca8ff000210805. |
The |
I have reviewed pr #456, and it is no problem, pls add some ut case |
Motivation
Vanus Functions are a series of pre-built functions worked within Vanus transformer. By choosing a function, users can specify the way that events will be changed.
It will be a good start if you decide to contribute to Vanus codes.
Details
Function name: now
Args
Description
The function is used to get the current time(format: yyyy-mm-dd hh:MM:SS) in a specific TimeZone. And assign it to the target JSON path. The Time Zone will be UTC if users don't specify it.
Example
After the function.
The transformed event should look like this:
How to implement
function-now
now.go
underinternal/primitive/transform/action/datatime
, and then implement the function.now.go
underinternal/primitive/transform/action/datatime
for unit test.internal/primitive/transform/runtime/init.go
.Contribution points
Each issue counts specific points based on its difficulty. Contributors earn the corresponding points if they solve that issue. Contribution points are used to describe the contributions contributors have made. They can also be used to get rewards when there are community events.
This issue counts 4 points.
How to claim to solve the issue
If you want to implement this function, please leave a comment in this issue like:
Vanus community will assign the issue to you on time.
The text was updated successfully, but these errors were encountered: