Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile with XCode 16.1 #14

Open
mynona opened this issue Aug 17, 2024 · 4 comments · May be fixed by #15
Open

Doesn't compile with XCode 16.1 #14

mynona opened this issue Aug 17, 2024 · 4 comments · May be fixed by #15

Comments

@mynona
Copy link

mynona commented Aug 17, 2024

Bildschirmfoto 2024-08-17 um 08 33 25

Issue exists also on XCode 15.4 with toolchain starting from 5.10.0

Thank you for looking into this, Tim!

@mynona
Copy link
Author

mynona commented Aug 17, 2024

@0xTim Hi, I found out that if I use as underlying cmark package the apple version your code compiles without issues:

.package(url: "https://github.com/apple/swift-cmark.git", from: "0.4.0"),

Copy-Pasted your wrapper code to test this.

Maybe this input is of use.

@0xTim
Copy link
Member

0xTim commented Aug 19, 2024

@mynona if you'd like to do a PR to point to that repo instead then that would be great. I'll poke people to see if we can get an actual release of the cmark library

@handya handya linked a pull request Oct 11, 2024 that will close this issue
@handya
Copy link

handya commented Oct 11, 2024

@0xTim @mynona I've done a PR for this #15

@0xTim 0xTim linked a pull request Oct 12, 2024 that will close this issue
@mynona
Copy link
Author

mynona commented Oct 12, 2024

Thank you @handya ,

There is also this repository (as pointed out by Tim):
https://github.com/swiftlang/swift-markdown

I migrated there. I found one rendering bug that I reported and unfortunately they have their versioning in sync with swift versions. Therefore, the markdown rendering feature is at the moment just part of the main branch.

Maybe to reflect if the official repo should be used in the future in general? The downside is that this repo is a very small wrapper over the c-library and the official swift repo is not that slim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants