Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame continuation ops code closes the websocket pipe reader prematurely. #133

Open
struktured opened this issue Dec 30, 2023 · 1 comment

Comments

@struktured
Copy link

struktured commented Dec 30, 2023

The react function, which is called upon each frame received, closes the pipe if the ops code is one of Opscode.Continuation | Opscode.Nonctrl _ | Opscode.Ctrl _, as defined here: https://github.com/vbmithr/ocaml-websocket/blob/master/async/websocket_async.ml#L172.

For the Opscode.Continuation case, it should properly implement the websocket protocol to concatenate the fragments. See this helpful blog post for more on the subject.

@vbmithr
Copy link
Owner

vbmithr commented Dec 30, 2023

Yo @struktured
Please use https://github.com/deepmarker/ocaml-fastws
I haven't touched this code for ages, while I use the latter in production.
It has the feature you need, BTW.
Best,
Vincent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants