Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(projects): Make arguments kw-only #364

Merged
merged 2 commits into from
May 29, 2022
Merged

Conversation

tony
Copy link
Member

@tony tony commented May 29, 2022

To make passing as a configuration file (#315 and vcs-python/vcspull#362) easier, deprecate positional arguments.

Deprecated in >=0.13:

GitProject('https://github.com/vcs-python/libvcs.git')

New style in >=0.13:

GitProject(url='https://github.com/vcs-python/libvcs.git')

See also:

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #364 (57e03f1) into master (2ecdc84) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   70.22%   70.25%   +0.03%     
==========================================
  Files          21       21              
  Lines        1857     1859       +2     
==========================================
+ Hits         1304     1306       +2     
  Misses        553      553              
Impacted Files Coverage Δ
libvcs/projects/base.py 100.00% <100.00%> (ø)
libvcs/projects/git.py 77.52% <100.00%> (+0.08%) ⬆️
libvcs/projects/svn.py 65.26% <100.00%> (+0.36%) ⬆️
libvcs/shortcuts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ecdc84...57e03f1. Read the comment docs.

@tony tony merged commit 7cdeb17 into master May 29, 2022
@tony tony deleted the projects-kwargs-only branch May 29, 2022 21:52
@tony tony added this to the v0.13 milestone May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant