Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Performance Test & Difference Output on PR #2653

Open
vankichi opened this issue Sep 30, 2024 · 0 comments
Open

[CI] Performance Test & Difference Output on PR #2653

vankichi opened this issue Sep 30, 2024 · 0 comments
Labels
priority/low status/help-wanted type/ci type/test Adding tests

Comments

@vankichi
Copy link
Contributor

Background:

We want to check whether the code changes in the PR have caused performance degradation

Describe the solution you'd like:

Display performance differences from the previous commit as comments on PR

Describe alternatives you've considered:

  • Upload performance test results (profile.tar.gz) to the artifact
  • Add a profile to vald-ci-images and comment on the difference with the previous commit on the PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/low status/help-wanted type/ci type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vankichi