Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for variable lenght Bloom filters #36

Open
daithihearn opened this issue Jul 22, 2021 · 1 comment
Open

Support for variable lenght Bloom filters #36

daithihearn opened this issue Jul 22, 2021 · 1 comment

Comments

@daithihearn
Copy link
Member

The current version appears to only support the older fixed length bloom filters. Are there plans to support the variable length bloom filters that were release in https://github.com/vechain/thor/releases/tag/v1.4.0 ?

@qianbin
Copy link
Member

qianbin commented Jul 22, 2021

the current bloom filter implementation in thor-devkit is kept just for backward compatibility.
almost all cases(actually I just saw in Connex), we just consume the bloom filter, which is simple like so:
https://github.com/vechain/connex/blob/master/packages/driver/src/bloom.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants