From b427b79bd7ff270bfed70c2e938e6e9e895b7aa7 Mon Sep 17 00:00:00 2001 From: Andres Perez Date: Wed, 6 Sep 2023 13:44:00 -0400 Subject: [PATCH 1/3] feat: support shareProcessNamespace is pod.spec --- charts/vector/templates/_pod.tpl | 3 +++ charts/vector/values.yaml | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/charts/vector/templates/_pod.tpl b/charts/vector/templates/_pod.tpl index 042d975..8a60c3d 100644 --- a/charts/vector/templates/_pod.tpl +++ b/charts/vector/templates/_pod.tpl @@ -16,6 +16,9 @@ priorityClassName: {{ . }} {{- with .Values.dnsPolicy }} dnsPolicy: {{ . }} {{- end }} +{{- with .Values.shareProcessNamespace }} +shareProcessNamespace: {{ . }} +{{- end }} {{- with .Values.dnsConfig }} dnsConfig: {{ toYaml . | indent 2 }} diff --git a/charts/vector/values.yaml b/charts/vector/values.yaml index f7c3af5..df05f92 100644 --- a/charts/vector/values.yaml +++ b/charts/vector/values.yaml @@ -399,6 +399,10 @@ dnsConfig: {} # value: "2" # - name: edns0 +# shareProcessNamespace -- Specify the [shareProcessNamespace](https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/) +# options for Vector Pods. +shareProcessNamespace: false + # livenessProbe -- Override default liveness probe settings. If customConfig is used, requires customConfig.api.enabled # to be set to true. livenessProbe: {} From 541e4f12ee196a9285c8873e609789fd005b4981 Mon Sep 17 00:00:00 2001 From: Roman Rinatovich <31822226+minebaev@users.noreply.github.com> Date: Wed, 6 Sep 2023 19:08:41 +0400 Subject: [PATCH 2/3] extraObjects fix lint (#325) fix lint --- charts/vector/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/charts/vector/README.md b/charts/vector/README.md index b46bb0b..4e2b38f 100644 --- a/charts/vector/README.md +++ b/charts/vector/README.md @@ -223,6 +223,7 @@ helm install --name \ | topologySpreadConstraints | list | `[]` | Configure [topology spread constraints](https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/) for Vector Pods. Valid for the "Aggregator" and "Stateless-Aggregator" roles. | | updateStrategy | object | `{}` | Customize the updateStrategy used to replace Vector Pods, this is also used for the DeploymentStrategy for the "Stateless-Aggregators". Valid options depend on the chosen role. | | workloadResourceAnnotations | object | `{}` | Set annotations on the Vector DaemonSet, Deployment or StatefulSet. | +| extraObjects | list | `[]` | Create extra manifests via values. Would be passed through `tpl` for templating. | ### HAProxy values From b56de88a564548dac916b63be2b41da3c289c3c6 Mon Sep 17 00:00:00 2001 From: Andres Perez <1676612+andresperezl@users.noreply.github.com> Date: Sun, 10 Sep 2023 21:19:11 -0400 Subject: [PATCH 3/3] chore: add `shareProcessNamespace` to README.md Additionally, move the `shareProcessNamespaces` in the `_pod.tpl`, before `dnsPolicy`, to keep dns values together in the template. --- charts/vector/README.md | 1 + charts/vector/templates/_pod.tpl | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/charts/vector/README.md b/charts/vector/README.md index 4e2b38f..ff612f3 100644 --- a/charts/vector/README.md +++ b/charts/vector/README.md @@ -218,6 +218,7 @@ helm install --name \ | serviceAccount.create | bool | `true` | If true, create a ServiceAccount for Vector. | | serviceAccount.name | string | `nil` | The name of the ServiceAccount to use. If not set and serviceAccount.create is true, a name is generated using the fullname template. | | serviceHeadless.enabled | bool | `true` | If true, create and provide a Headless Service resource for Vector. | +| shareProcessNamespace | bool | `false` | Specify the [shareProcessNamespace](https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/) options for Vector Pods. | | terminationGracePeriodSeconds | int | `60` | Override Vector's terminationGracePeriodSeconds. | | tolerations | list | `[]` | Configure Vector Pods to be scheduled on [tainted](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) nodes. | | topologySpreadConstraints | list | `[]` | Configure [topology spread constraints](https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/) for Vector Pods. Valid for the "Aggregator" and "Stateless-Aggregator" roles. | diff --git a/charts/vector/templates/_pod.tpl b/charts/vector/templates/_pod.tpl index 8a60c3d..33e78a9 100644 --- a/charts/vector/templates/_pod.tpl +++ b/charts/vector/templates/_pod.tpl @@ -13,12 +13,12 @@ securityContext: {{- with .Values.podPriorityClassName }} priorityClassName: {{ . }} {{- end }} -{{- with .Values.dnsPolicy }} -dnsPolicy: {{ . }} -{{- end }} {{- with .Values.shareProcessNamespace }} shareProcessNamespace: {{ . }} {{- end }} +{{- with .Values.dnsPolicy }} +dnsPolicy: {{ . }} +{{- end }} {{- with .Values.dnsConfig }} dnsConfig: {{ toYaml . | indent 2 }}