Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS_S3 source: Add metrics support #21899

Open
GGonzalezGomez opened this issue Nov 27, 2024 · 2 comments
Open

AWS_S3 source: Add metrics support #21899

GGonzalezGomez opened this issue Nov 27, 2024 · 2 comments
Labels
source: aws_s3 Anything `aws_s3` source related type: feature A value-adding code addition that introduce new functionality.

Comments

@GGonzalezGomez
Copy link

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

AWS metric streams allows to send metrics to S3 (through firehose) in otel format or json. The use case would be vector picking up these metric files and processing them in the pipeline.

Attempted Solutions

We use aws_s3 source for logs, picking up log files through SQS messages. This is working for us properly. So we would also like to extend this for metrics as well as AWS Cloudwatch can dump metrics into S3 as well.

Proposal

AWS_S3 source already allows to pick up log files. In the documentation output is mentioned only for logs, so the idea would be to be able to extend this functionality for metrics as well. That way you may either read a bunch of files from S3 for processing or read an SQS queue for new file notifications and keep sending metrics through S3.
Again, this is already available for logs, just extending the functionality for metric signal as well.

References

No response

Version

0.33 and 0.37

@GGonzalezGomez GGonzalezGomez added the type: feature A value-adding code addition that introduce new functionality. label Nov 27, 2024
@pront pront added the source: aws_s3 Anything `aws_s3` source related label Nov 27, 2024
@jszwedko
Copy link
Member

jszwedko commented Dec 2, 2024

The aws_s3 sink can already decode metrics, but only if they are encoded in one of the currently supported metric codecs. These would be: native_json, native, and influxdb. I think this feature could be supported by:

  • Adding an otlp codec that could decode OTLP events
  • Adding an aws_metric_json codec that understands how to decode the AWS metric JSON format

@GGonzalezGomez
Copy link
Author

That makes sense, if it accepts already metrics having support to at least OTLP (AWS can output both 0.7 and 1.0 format) would be fantastic.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: aws_s3 Anything `aws_s3` source related type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

3 participants