Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure on Python 3.4 / drop support? #343

Open
magical opened this issue Apr 2, 2021 · 1 comment
Open

Failure on Python 3.4 / drop support? #343

magical opened this issue Apr 2, 2021 · 1 comment

Comments

@magical
Copy link
Member

magical commented Apr 2, 2021

I'm seeing a new build failure on Python 3.4.

https://travis-ci.org/github/veekun/pokedex/jobs/765569618#L241

File "/home/travis/virtualenv/python3.4.8/lib/python3.4/site-packages/sqlalchemy/util/compat.py", line 189, in

from typing import TYPE_CHECKING

ImportError: No module named 'typing'

Looks like a recently introduced incompatibility in sqlalchemy. I could investigate further, but I'm inclined to just drop Python 3.4 from the test matrix since it is past its expiration date.

Any objections?

@Parnassius
Copy link
Contributor

For what is worth, this should be fixed in the next sqlalchemy 1.3.x patch release: sqlalchemy/sqlalchemy#6168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants