Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out caching in pyramid #128

Open
magical opened this issue Jul 16, 2019 · 1 comment
Open

Figure out caching in pyramid #128

magical opened this issue Jul 16, 2019 · 1 comment

Comments

@magical
Copy link
Member

magical commented Jul 16, 2019 •
edited
Loading

part of #115
@magical
Copy link
Member Author

magical commented Jul 16, 2019

Got beaker working but i kind of hate it. Should maybe look into dogpile.cache.

magical added a commit to magical/spline-pokedex that referenced this issue Jul 16, 2019
@magical
Get caching working (first pass)
6404c80 
pyramid_beaker does pretty much nothing for us here. It configures cache
regions, but we don't actually use them, so we have to set everything up
ourselves.

This (re-)adds caching to the pokemon page. Other pages that used to be
cached are now broken, but i'll fix them in upcoming commits.

Updates veekun#128
magical added a commit to magical/spline-pokedex that referenced this issue Jul 16, 2019
@magical
Cache the remaining pages that should be cached
4ed803e 
Add caching to all the pages that formerly had been cached in
spline-pokedex.

Also drop the template argument from cache_content, since unlike spline
it isn't responsible for rendering the template. We still need something
to use as the cache key, so use the do_work function name instead, same
as beaker does for decorated functions.

Updates veekun#128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magical