Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future maintainer #259

Open
128keaton opened this issue Jul 27, 2023 · 12 comments
Open

Future maintainer #259

128keaton opened this issue Jul 27, 2023 · 12 comments

Comments

@128keaton
Copy link

Hello, I'd love to maintain this project seeing as how I use it quite a bit.

I have a fork located here that I created to add some options

Funnily enough, I noticed that this would effectively close #92

@tommyc38
Copy link

tommyc38 commented Aug 8, 2023

@128keaton I'd be happy to help after December. I am going to be starting a big Nest.js project and have been searching for sort of the holy grail of fullstack development (e.g. one source source of truth for db, dto, swagger, and validation that can be used on both the frontend and backend). I would really like to bring validation via class-validator into this project as an option in addition to enhancing the current project. Let me know if you are open to that.

@128keaton
Copy link
Author

@tommyc38 That sounds fantastic, I've been wanting something similar to create standardized interfaces for filtering/pagination too, so we have plenty of ideas.

@ChristopherCapito
Copy link

I suggest linking up with https://github.com/Brakebein/prisma-generator-nestjs-dto

He has some very cool additions with relation to compound types and such. might be worth a conversation. used his fork extensively

@Arkanii
Copy link

Arkanii commented Aug 21, 2023

Agree with @ChristopherCapito

I've seen many forks and it can be interesting to focus on a multi-person project, and I think @Brakebein's one is a good candidate in terms of features and popularity.

What do you think about that ?

I mention all people who have done something or wanted to maintain the project :

@Brakebein
@128keaton
@tommyc38
@botika
@liliwei25

@tommyc38
Copy link

I agree. I think @Brakebein's repo looks promising. I also didn't realize he already has support for class-validator. I think it makes sense to partner up there to extend the package further.

@Brakebein
Copy link

Thanks for the credits. Indeed, my fork had evolved quite a lot, since I use it in some of my projects and added the features I needed. But many others also contributed from time to time with suggestions or pull requests (see changelog for all additions and fixes).

I am open to synchronize with you. Do you have any ideas how to proceed? Or what are your ideas how to contribute?

@zzau13
Copy link

zzau13 commented Aug 25, 2023

https://github.com/botika/prisma-generator-nestjs-dto Here the class-validators work, I use babel, but the original structure doesn't work for me and I have to do a refactor.
It is in development but I am using it in production, it has errors due to the original structure that I will fix in a couple of weeks.

@Arkanii
Copy link

Arkanii commented Aug 28, 2023

Is there a way to merge your two project's ideas together and maintain the new one / existing one as a team ?

@okonon
Copy link

okonon commented Aug 28, 2023

I'd be interested to contribute with my fork as well forked from @Brakebein . I had a need to add ApiHideProperty to hide createdBy and updatedBy fields from swagger but not fail validation with whitelist and forbidNonWhitelisted set to true.

@zzau13
Copy link

zzau13 commented Aug 28, 2023

I am willing to give the little code that I have done to a team and take it together. Now, I am applying solid principles on the structure for easy extension.

@Brakebein
Copy link

I'd be interested to contribute with my fork as well forked from @Brakebein . I had a need to add ApiHideProperty to hide createdBy and updatedBy fields from swagger but not fail validation with whitelist and forbidNonWhitelisted set to true.

@okonon I added ApiHideProperty last month based on your request (Brakebein#23).

@okonon
Copy link

okonon commented Sep 6, 2023

@Brakebein super! i really appreciate it your implementation is way cleaner then mine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

7 participants