Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer ClojureScript versions clashes with rrb-vector which prevents building #90

Open
AriPaaWun opened this issue Jun 12, 2018 · 4 comments

Comments

@AriPaaWun
Copy link

Hi,

I ran into problem where my builds failed when using newer version of ClojureScript because it clashes with rrb-vector version 0.0.11. More about this problem here: brandonbloom/fipp#42

Dependecy goes like this Ultra -> puget -> fipp -> rrb-vector
Here is the open issue to fix it in cljs-build emezeske/lein-cljsbuild#469

As such I cannot use Ultra. You could override the rrb-vector dependency with this version [quantum/org.clojure.core.rrb-vector "0.0.12"] to make it usable again.

@venantius
Copy link
Owner

Thanks for posting this. I'm going to have to take Brandon's position - this is sounds like a problem to be fixed upstream rather than here. But for those who want a quick fix, you should be able to use :exclusions to achieve what you want.

@jvtrigueros
Copy link

jvtrigueros commented Nov 21, 2018

For me, this eliminated the issues:

{:user {:dependencies [[org.clojure/core.rrb-vector "0.0.13"]]
        :plugins [[org.clojure/core.rrb-vector "0.0.13"]
                  [venantius/ultra "0.5.2" :exclusions [org.clojure/clojure
                                                        org.clojure/core.rrb-vector]]]}}

I was seeing the error mentioned above when running on JDK 11

@lvh
Copy link

lvh commented Dec 10, 2018

@venantius The rrb-vector dependency also affects JDK11, not just ClojureScript. AFAICT the fipp ticket is a bit of a red herring: someone, somewhere, needs to pull in a newer version of rrb-vector, cut a new release, and ultra needs to update the dep. You could work around it in ultra, but I agree that's not super appropriate :)

@vise890-ovo
Copy link

I think @lvh is right, and puget seems to be the culprit:

;; from lein deps :tree
 [mvxcvi/puget "1.1.0"]
   [fipp "0.6.14"]
     [org.clojure/core.rrb-vector "0.0.13"]

Puget is on version 1.1.1 now, which pulls the correct rrb-vector through a newer version of fipp.

I think bumping ultra's dep to [mvxcvi/puget "1.1.1"] should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants