You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, while integrating VENTokenField into our app we noticed that as you create more tokens, the VENTokenField keeps laying them out starting at the same point. After some debugging, the issue is in layoutCollapsedLabelWithCurrentX, where layout values are calculated like *currentX += token.width + self.tokenPadding;. Since UIView's width is already claimed by Masonry in our project for auto-layout, token.width ends up returning 0 which, obviously, totally borks the layout.
We'd like to get this merged back to the main repo, and to do it properly we should remove the dependency on FrameAccessor. Masonry has an option to use mas_width instead of width, but we actually use Masonry's shortcuts directly, and in general it's a much more commonly used library. It seems the shortcuts are only used in VENTokenField.m, so I believe we've made all the changes.
If we get someone's blessing, we'll make a PR that removes the FrameAccessor dependency with the adaptions.
Hi, while integrating VENTokenField into our app we noticed that as you create more tokens, the
VENTokenField
keeps laying them out starting at the same point. After some debugging, the issue is inlayoutCollapsedLabelWithCurrentX
, where layout values are calculated like*currentX += token.width + self.tokenPadding;
. SinceUIView
'swidth
is already claimed by Masonry in our project for auto-layout,token.width
ends up returning0
which, obviously, totally borks the layout.We've fixed it in our fork so that it doesn't use the shortcuts, you can see that here: https://github.com/jaredegan/VENTokenField/pull/1/files
We'd like to get this merged back to the main repo, and to do it properly we should remove the dependency on FrameAccessor. Masonry has an option to use
mas_width
instead ofwidth
, but we actually use Masonry's shortcuts directly, and in general it's a much more commonly used library. It seems the shortcuts are only used inVENTokenField.m
, so I believe we've made all the changes.If we get someone's blessing, we'll make a PR that removes the FrameAccessor dependency with the adaptions.
@welsny
-- A fellow PayPalian
The text was updated successfully, but these errors were encountered: