Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Need to make an Architectural choice to decide, whether to define Store Policy and expose it to consumers #86

Open
yogeshbdeshpande opened this issue Nov 18, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@yogeshbdeshpande
Copy link
Collaborator

Need: Endorsements are of different nature, Integrity or Integrity and Privacy Protected, hence each type of Endorsement may need a different protection, Hence the need for different type of stores. This requires a Policy to be defined.

@yogeshbdeshpande yogeshbdeshpande added the enhancement New feature or request label Nov 18, 2022
@yogeshbdeshpande
Copy link
Collaborator Author

Policy layer has a bearing on the API defined in the vts.proto.

Should we have a single API AddEndorsementRequest() where the policy is negotiated upfront?

See also issue veraison/veraison#151

@yogeshbdeshpande
Copy link
Collaborator Author

yogeshbdeshpande commented Nov 18, 2022

Notes from @setrofim

Different security requirements for different types of endorsements do not necessitate different stores -- as long as the one store meets the union of these requirements.

A particular setup may benefit from (or even require) multiple stores, so we should definitely allow a multi-store configurations, however there is no need to mandate it (let alone mandate specific kinds of stores). Setting up multiple stores increases the complexity of deployments. We should not require this complexity for deployments that don't need them.

We do need to establish a store configuration four our "default"/"standard" Veraison configuration (our current situation of a trust anchor store and other endorsements store seems reasonable), but we should not require it by having it explicitly reflected in the APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant