Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "products" menu entry from Craft Commerce #120

Open
goraxan opened this issue Jan 18, 2023 · 3 comments
Open

Missing "products" menu entry from Craft Commerce #120

goraxan opened this issue Jan 18, 2023 · 3 comments

Comments

@goraxan
Copy link

goraxan commented Jan 18, 2023

Describe the bug

After installing Craft Commerce (v4.2.4) I've noticed that the "Products" menu entry is missing, it only shows up if I disable the cp-nav plugin. Looks like it doesn't detect it
image
Whereas if I disable the plugin, it's shown properly
image

Steps to reproduce

  1. Install cp-nav
  2. Install craft commerce
  3. Products entry is not shown under Commerce section
  4. Disable cp-nav
  5. Products entry is shown

Craft CMS version

4.3.6.1

Plugin version

4.0.9

Multi-site?

No

Additional context

No response

@engram-design
Copy link
Member

This would be due to the conditional logic of only showing products when there are product types. We don't currently check for subnav items on whether they're updated or not (we do for top level items) purely for performance reasons. We really want to minimise the amount of queries run on a CP page request.

The only course of action is to reset the nav (or add the nav item yourself, manually) for the time being.

@goraxan
Copy link
Author

goraxan commented Jan 19, 2023

Ok, that make sense. It'd be nice to have a "refresh" button to regenerate the entries without loosing your manual changes, though.
For now I'll just manually add the "products" entry since I don't want to loose my other manual changes by resetting the nav.

@engram-design
Copy link
Member

Yep, a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants